feat(pdo): add from-connection to wrap an existing PDO#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
pdo/from-connectionso Phel can reuse a host framework's already-open\PDO(Symfony/Laravel + Doctrine DBAL'sgetNativeConnection()) instead of opening a second connection:Behaviour (per #21):
Returns the standard
connectionvalue, so every downstream fn (query,prepare,execute,fetch,insert,begin/commit/rollback,with-transaction, ...) works unchanged.Leaves attributes untouched by default - the host owns the connection's configuration.
{:apply-defaults true}opts into phel-pdo'sERRMODE_EXCEPTION.Lifecycle: phel-pdo never closes a connection it did not open (the library exposes no close, so a wrapped handle is never closed by it).
Tests: wrap a pre-opened in-memory SQLite
\PDOand run query/fetch; run awith-transaction; verify default leavesERRMODEas set by the host (SILENT preserved) and:apply-defaultsforcesERRMODE_EXCEPTION.README API table +
docs/recipes.md"reuse an existing (framework) connection" section + CHANGELOG updated.Polish pass: no refactor needed - reuses the
connectionstruct andset-attribute; no duplication.composer testgreen (60 assertions).Closes #21