feature(angular ✨): report all angular diagnostics #1236
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a large code base with 19'000 issues Angular tests are not reporting .html errors even when the option
strictTemplatesis passed.This is because Angular defaultGatherDiagnostics doesn't continue gathering diagnostics if some diagnostic checks fail.
This PR is a start for a discussion on how we want to introduce the changes, without breaking behavior.
So far this is a breaking change as now all errors will be reported.
But we could solve this for instance via a configuration and switch between default behavior and a report all at once behavior.
Other ideas are welcome.