fix standalone rules (placing artefacts in root); tidy up standalone rules #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify -output-directory to *latexmk*, which fixes placing the standalone chapter PDFs in the chapter sub-directories instead of the root. latexmk also correctly propagates this option to pdflatex, meaning we don't need to redefine it. latexmk also defaults auxdir to output-directory, so we don't need to specify that. Signed-off-by: Jonathan Dowland <[email protected]>
The phony clean and purge rules were incorrectly specified in terms of the source files, not the destinations (e.g. expanding to "clean/chapter1-standalone.tex"). Avoid defining two variables STANDALONE and standalone; use STANDALONE_SOURCES for the former and STANDALONE for the latter. Define phone 'clean-standalone' and 'purge-standalone' rules; group them with the phony 'standalone' rule. Depend upon these later instead of doing addprefix calculations in the dependency list for clean/purge. declare all three .PHONY within this section of the Makefile so all the standalone stuff is together; remove the subsequent declaration in the bottom-most .PHONY. Signed-off-by: Jonathan Dowland <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify -output-directory to latexmk, which fixes placing the
standalone chapter PDFs in the chapter sub-directories instead of the
root.
latexmk also correctly propagates this option to pdflatex, meaning we
don't need to redefine it.
latexmk also defaults auxdir to output-directory, so we don't need to
specify that.
The phony clean and purge rules were incorrectly specified in terms
of the source files, not the destinations (e.g. expanding to
"clean/chapter1-standalone.tex").
Avoid defining two variables STANDALONE and standalone; use
STANDALONE_SOURCES for the former and STANDALONE for the latter.
Define phone 'clean-standalone' and 'purge-standalone' rules; group
them with the phony 'standalone' rule. Depend upon these later
instead of doing addprefix calculations in the dependency list for
clean/purge.
declare all three .PHONY within this section of the Makefile so all
the standalone stuff is together; remove the subsequent declaration
in the bottom-most .PHONY.