Update configure.sh to move agents.json #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First writing whole agents.json and moving it afterwards in place to prevent "unexpected end of JSON input" errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First writing whole agents.json and moving it afterwards in place to prevent "unexpected end of JSON input" errors.
caller=file.go:205 component="target manager" discovery=file msg="Error reading file" path=/tmp/agents.json err="unexpected end of JSON input"The "move" operation is faster since it is only an Inode operation, which causes prometheus always to see the complete file and not only parts, if fetching data from mesos api takes longer.