Skip to content

Conversation

@waseem-omar
Copy link

No description provided.

@mfaulkner9294
Copy link

Looks good to me...

@0xLuz
Copy link

0xLuz commented Feb 9, 2020

Did you run the tests with Django 3?

python manage.py test geoposition

I tried this and it's not working. You need to change the urls formats and some other requirements for Django 3.

The tests work for this PR because they were not updated: https://github.com/philippbosch/django-geoposition/blob/master/.travis.yml

Copy link

@kallewesterling kallewesterling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like an easy way to implement django 3 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants