Skip to content

Commit

Permalink
Bump devcontainer image to LTS Node and Stable Debain
Browse files Browse the repository at this point in the history
  • Loading branch information
marcofranssen committed Dec 20, 2024
1 parent e1022c1 commit d2a979f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 22 deletions.
2 changes: 1 addition & 1 deletion .devcontainer/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mcr.microsoft.com/devcontainers/typescript-node:1-18-bullseye
FROM mcr.microsoft.com/devcontainers/typescript-node:1-20-bookworm

# Install isolate-vm dependencies, these are needed by the @backstage/plugin-scaffolder-backend.
RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
Expand Down
22 changes: 1 addition & 21 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ following:
```json
scripts: {
// ...
"dev": "yarn workspaces foreach -A --include backend --include app --parallel -j unlimited -v -i run start",
"dev": "NODE_OPTIONS=--no-node-snapshot yarn workspaces foreach -A --include backend --include app --parallel -j unlimited -v -i run start",
// ...
}
```
Expand Down Expand Up @@ -119,26 +119,6 @@ you don't see the Backstage app running, please check the following:
and 7007. The codespace is mapping the ports to your local ports. Ensure
you have no other processes running on those ports and both ports are mapped, you may have to manually add port 7007 in the vscode UI.

??? Note "Node 20"

If you are running node 20 you will need to set the `NODE_OPTIONS=--no-node-snapshot`
environment variable to prevent the node process from crashing.

You can do this in a few ways, such as running
`NODE_OPTIONS=--no-node-snapshot yarn dev` each time you start the app, or
by adding it to the `dev` script in the `package.json`.

The Codespace is running on Node 18, so you should not have this issue.

??? Note Node 20

If you are running node 20 you will need to set the `NODE_OPTIONS=--no-node-snapshot`
environment variable to prevent the node process from crashing.

You can do this in a few ways, such as running
`NODE_OPTIONS=--no-node-snapshot yarn dev` each time you start the app, or
by adding it to the `dev` script in the `package.json`.

## Authentication

For this workshop we will need to authenticate with GitHub in order to create
Expand Down

0 comments on commit d2a979f

Please sign in to comment.