Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rust container flavor #351

Merged
merged 43 commits into from
May 8, 2024
Merged

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Mar 8, 2024

Pull Request

Description of changes

This PR adds a container flavor to amp-devcontainer that enables rust development.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner March 8, 2024 14:48
Copy link
Contributor

github-actions bot commented Mar 8, 2024

Test Results

 2 files  +1   2 suites  +1   51s ⏱️ +10s
26 tests +6  26 ✅ +6  0 💤 ±0  0 ❌ ±0 
28 runs  +8  28 ✅ +8  0 💤 ±0  0 ❌ ±0 

Results for commit e7e6d74. ± Comparison against base commit 5804c2b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 8, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 14 0 0.04s
✅ DOCKERFILE hadolint 2 0 0.4s
✅ JSON prettier 11 0 0 0.89s
✅ JSON v8r 11 0 130.28s
✅ MARKDOWN markdownlint 8 0 0 1.06s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.26s
✅ REPOSITORY checkov yes no 10.52s
✅ REPOSITORY gitleaks yes no 0.23s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 7.84s
✅ REPOSITORY secretlint yes no 1.59s
✅ REPOSITORY trivy yes no 4.51s
✅ REPOSITORY trivy-sbom yes no 1.91s
✅ REPOSITORY trufflehog yes no 2.5s
✅ SPELL lychee 48 0 1.06s
✅ YAML prettier 19 0 0 1.24s
✅ YAML v8r 19 0 217.28s
✅ YAML yamllint 19 0 0.39s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

.devcontainer/rust/Dockerfile Fixed Show fixed Hide fixed
.devcontainer/rust/Dockerfile Fixed Show fixed Hide fixed
.devcontainer/rust/Dockerfile Fixed Show fixed Hide fixed
@rjaegers rjaegers marked this pull request as draft March 12, 2024 14:14
Copy link
Contributor

github-actions bot commented Mar 13, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:016b8f10b0792fbfbd2b69e0b9b2ffc29b2c043e00e875d19f53b0ccf6c19d4e

OS/Platform Previous Size Current Size Delta

Copy link
Contributor

github-actions bot commented Mar 13, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:c90159f6718e69d843322500eb8ce832edda0412a64b306614706cd14960380b

OS/Platform Previous Size Current Size Delta

.devcontainer/rust/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/rust/test/cortex-m/Cargo.lock Show resolved Hide resolved
@rjaegers
Copy link
Member Author

rjaegers commented Apr 20, 2024

TODO

  • Merge -vscode version with containers and document architectural decision
  • Update size comparison from image
  • Update documentation
  • Update required checks now that a matrix is used

.devcontainer/rust/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/rust/Dockerfile Show resolved Hide resolved
@rjaegers rjaegers marked this pull request as ready for review May 6, 2024 14:15
@rjaegers rjaegers enabled auto-merge May 8, 2024 12:30
@rjaegers rjaegers added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit f7b357b May 8, 2024
16 checks passed
@rjaegers rjaegers deleted the feature/add-rust-container-flavor branch May 8, 2024 14:11
Copy link
Contributor

github-actions bot commented May 8, 2024

Pull Request Report (#351)

Static measures

Description Value
Number of added lines 819
Number of deleted lines 250
Number of changed files 68
Number of commits 43
Number of reviews 9
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 8
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 6

Time related measures

Description Value
PR lead time (from creation to close of PR) 61 Days
Time that was spend on the branch before the PR was created 1.3 Min
Time that was spend on the branch before the PR was merged 61 Days
Time to merge after last review 16 Days

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 7.7 Hours
Total time spend in last status check run on PR 5.3 Hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants