Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix update apt packages action #415

Merged
merged 2 commits into from
May 15, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented May 15, 2024

Pull Request

Description of changes

This PR fixes incorrect usage of sudo in the update apt packages action. This action is run inside our container context, which runs as root and has no sudo installed.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner May 15, 2024 07:15
Copy link
Contributor

github-actions bot commented May 15, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 14 0 0.05s
✅ DOCKERFILE hadolint 2 0 0.39s
✅ JSON prettier 11 0 0 0.95s
✅ JSON v8r 10 0 4.18s
✅ MARKDOWN markdownlint 8 0 0 1.03s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.27s
✅ REPOSITORY checkov yes no 15.06s
✅ REPOSITORY gitleaks yes no 0.23s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 14.46s
✅ REPOSITORY secretlint yes no 1.8s
✅ REPOSITORY trivy yes no 9.36s
✅ REPOSITORY trivy-sbom yes no 2.24s
✅ REPOSITORY trufflehog yes no 3.48s
✅ SPELL lychee 48 0 1.14s
✅ YAML prettier 19 0 0 1.24s
✅ YAML v8r 19 0 11.28s
✅ YAML yamllint 19 0 0.38s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented May 15, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:9701ea8180650732b980872e703bb761377754c959c60172c521518ed13ddba4

OS/Platform Previous Size Current Size Delta
linux/amd64 491.81M 491.79M -17.26K (-0.00%)
linux/arm64 630.31M 630.32M 12.24K (+0.00%)

The update-apt-packages action runs in our own container context which does not have sudo installed.
@rjaegers rjaegers force-pushed the feature/fix-update-apt-packages-action branch from ef3b034 to 10aedb2 Compare May 15, 2024 07:17
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rjaegers rjaegers enabled auto-merge May 15, 2024 07:40
Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   52s ⏱️ ±0s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3776fff. ± Comparison against base commit 212a7ed.

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:c0a621cf1bff8e7fda376167be23bd5a49f0f0e560c38998c3ed1c42e186dfa6

OS/Platform Previous Size Current Size Delta
linux/amd64 632.00M 632.00M -445.00 (-0.00%)
linux/arm64 624.80M 624.80M -202.00 (-0.00%)

@rjaegers rjaegers added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 7fdfc9b May 15, 2024
27 checks passed
@rjaegers rjaegers deleted the feature/fix-update-apt-packages-action branch May 15, 2024 17:59
Copy link
Contributor

Pull Request Report (#415)

Static measures

Description Value
Number of added lines 2
Number of deleted lines 2
Number of changed files 2
Number of commits 2
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 10.7 Hours
Time that was spend on the branch before the PR was created 0 Sec
Time that was spend on the branch before the PR was merged 10.7 Hours
Time to merge after last review 10.4 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 5.7 Hours
Total time spend in last status check run on PR 5.3 Hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants