Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add scope to GitHub Actions Docker build cache #449

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jun 12, 2024

Pull Request

Description of changes

Since the introduction of multiple container flavors built from a ci matrix build, the scope property should be used to prevent overwriting of the Docker layer cache.

See: https://stackoverflow.com/questions/76227392/github-build-push-action-and-gha-cache-should-i-set-the-github-ref-name-in-the and https://docs.docker.com/build/cache/backends/gha/#scope.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner June 12, 2024 08:41
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 14 0 0.07s
✅ DOCKERFILE hadolint 2 0 0.62s
✅ JSON prettier 11 0 0 0.99s
✅ JSON v8r 10 0 4.71s
✅ MARKDOWN markdownlint 8 0 0 1.15s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.28s
✅ REPOSITORY checkov yes no 18.32s
✅ REPOSITORY gitleaks yes no 0.5s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 14.51s
✅ REPOSITORY secretlint yes no 1.76s
✅ REPOSITORY trivy yes no 7.4s
✅ REPOSITORY trivy-sbom yes no 2.37s
✅ REPOSITORY trufflehog yes no 3.87s
✅ SPELL lychee 48 0 1.27s
✅ YAML prettier 19 0 0 1.34s
✅ YAML v8r 19 0 16.43s
✅ YAML yamllint 19 0 0.34s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:18ef0f35298987387587a1f6235d1ad47695f11d62585a8d9f5f292ef92558bf

OS/Platform Previous Size Current Size Delta
linux/amd64 432.86M 432.86M -314.00 (-0.00%)
linux/arm64 572.09M 572.09M -46.00 (-0.00%)

Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   51s ⏱️ -1s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3c2eb40. ± Comparison against base commit 428570c.

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:179fb7aad4eeaa9410d44ea9017a3641013f84b4a7c00f781b6dc2d52767f340

OS/Platform Previous Size Current Size Delta
linux/amd64 640.27M 640.27M -2.96K (-0.00%)
linux/arm64 632.60M 632.62M 16.42K (+0.00%)

@rjaegers rjaegers added this pull request to the merge queue Jun 13, 2024
Merged via the queue into main with commit a0bc7a6 Jun 13, 2024
21 checks passed
@rjaegers rjaegers deleted the feature/fix-docker-build-cache branch June 13, 2024 12:07
Copy link
Contributor

Pull Request Report (#449)

Static measures

Description Value
Number of added lines 5
Number of deleted lines 6
Number of changed files 3
Number of commits 1
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 1.1 Days
Time that was spend on the branch before the PR was created 1.9 Min
Time that was spend on the branch before the PR was merged 1.1 Days
Time to merge after last review 5.3 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 6.1 Hours
Total time spend in last status check run on PR 1.1 Days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants