Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to Noble (24.04) packages for apt.llvm.org #460

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jun 19, 2024

Pull Request

Description of changes

This PR removes the temporary workaround to include Mantic packages for apt.llvm.org as Noble packages were not yet available.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner June 19, 2024 14:46
Copy link
Contributor

github-actions bot commented Jun 19, 2024

Test Results

 2 files  ±0   2 suites  ±0   53s ⏱️ -1s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 7fc8e7a. ± Comparison against base commit 1cabb71.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jun 19, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 14 0 0.05s
✅ DOCKERFILE hadolint 2 0 0.51s
✅ JSON prettier 11 0 0 0.59s
✅ JSON v8r 10 0 4.45s
✅ MARKDOWN markdownlint 8 0 0 0.94s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.2s
✅ REPOSITORY checkov yes no 15.75s
✅ REPOSITORY gitleaks yes no 0.39s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.13s
✅ REPOSITORY secretlint yes no 1.16s
✅ REPOSITORY trivy yes no 6.32s
✅ REPOSITORY trivy-sbom yes no 3.97s
✅ REPOSITORY trufflehog yes no 3.4s
✅ SPELL lychee 48 0 0.98s
✅ YAML prettier 19 0 0 0.94s
✅ YAML v8r 19 0 12.22s
✅ YAML yamllint 19 0 0.36s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

@magi-arun magi-arun requested a review from EkelmansPh June 20, 2024 07:21
Copy link

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:75c95cf141c3fb54579082dcbbf57bde5677f82164266e989f1bbd4a7ca77b60

OS/Platform Previous Size Current Size Delta
linux/amd64 432.86M 432.86M -256.00 (-0.00%)
linux/arm64 572.09M 572.09M 19.00 (+0.00%)

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:0be8e3ae2234ae33f5e32aae3f40dafee44b117357b1a3921da1fc4fbe1a3ab1

OS/Platform Previous Size Current Size Delta
linux/amd64 640.27M 640.66M 399.28K (+0.06%)
linux/arm64 632.60M 633.02M 428.16K (+0.07%)

@rjaegers rjaegers enabled auto-merge June 20, 2024 16:39
@rjaegers rjaegers added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit ced451d Jun 21, 2024
17 checks passed
@rjaegers rjaegers deleted the feature/noble-apt-llvm-org branch June 21, 2024 12:37
Copy link
Contributor

Pull Request Report (#460)

Static measures

Description Value
Number of added lines 11
Number of deleted lines 11
Number of changed files 2
Number of commits 2
Number of reviews 4
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 3
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 1.9 Days
Time that was spend on the branch before the PR was created 1.4 Min
Time that was spend on the branch before the PR was merged 1.9 Days
Time to merge after last review 4.9 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 5.3 Hours
Total time spend in last status check run on PR 5 Hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants