Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: make vscode extension update more generic #471

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jun 25, 2024

Pull Request

Description of changes

The input to the update-vscode-extensions action can now be a default devcontainer.json file. This enables running the update action against standard devcontainer.json files.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

The input to the update-vscode-extensions action can now be a default devcontainer.json file.
@rjaegers rjaegers requested a review from a team as a code owner June 25, 2024 11:12
Copy link

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:b4629cd0d17704a3db5d9b709a4883e7aca6e7e0b162438c5c65f8e8a274b106

OS/Platform Previous Size Current Size Delta
linux/amd64 640.66M 640.66M 0.00 (+0.00%)
linux/arm64 633.02M 633.02M 0.00 (+0.00%)

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 14 0 0.05s
✅ DOCKERFILE hadolint 2 0 0.5s
✅ JSON prettier 11 0 0 0.64s
✅ JSON v8r 10 0 4.37s
✅ MARKDOWN markdownlint 8 0 0 0.97s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.21s
✅ REPOSITORY checkov yes no 17.84s
✅ REPOSITORY gitleaks yes no 0.29s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY grype yes no 14.54s
✅ REPOSITORY secretlint yes no 1.26s
✅ REPOSITORY trivy yes no 7.96s
✅ REPOSITORY trivy-sbom yes no 2.19s
✅ REPOSITORY trufflehog yes no 3.5s
✅ SPELL lychee 48 0 1.52s
✅ YAML prettier 19 0 0 0.87s
✅ YAML v8r 19 0 13.83s
✅ YAML yamllint 19 0 0.46s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:e66f69793d833a39542eb192165e98d40ca3c7b4343713c8f3457387f0a4fe72

OS/Platform Previous Size Current Size Delta
linux/amd64 432.86M 432.86M 0.00 (+0.00%)
linux/arm64 572.09M 572.09M 0.00 (+0.00%)

Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   51s ⏱️ -1s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 70be138. ± Comparison against base commit 24d6697.

Copy link

@BarisTanyeri BarisTanyeri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! devcontainer.json is now consolidated!
Have you also considered using the "features" key? This may help with debloating the image

"features": { "ghcr.io/devcontainers/features/git:1": {}, "ghcr.io/devcontainers-contrib/features/ccache-asdf:2": {}, "ghcr.io/devcontainers-contrib/features/curl-apt-get:1": {}, "ghcr.io/devcontainers-contrib/features/wget-apt-get:1": {} }

@rjaegers rjaegers added this pull request to the merge queue Jun 26, 2024
Merged via the queue into main with commit 09a6958 Jun 26, 2024
22 checks passed
@rjaegers rjaegers deleted the feature/ci-generalize-vscode-extension-updates branch June 26, 2024 06:58
Copy link
Contributor

Pull Request Report (#471)

Static measures

Description Value
Number of added lines 47
Number of deleted lines 51
Number of changed files 5
Number of commits 2
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 19.8 Hours
Time that was spend on the branch before the PR was created 1.8 Min
Time that was spend on the branch before the PR was merged 19.8 Hours
Time to merge after last review 19.3 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 13.3 Min
Total time spend in last status check run on PR 19.6 Hours

Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.1.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants