Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove duplication in cpp testsuite #482

Merged
merged 2 commits into from
Jul 4, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jul 2, 2024

Pull Request

Description of changes

Remove duplicated code in .devcontainer/cpp/test/testsuite.bats

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner July 2, 2024 10:14
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:aef5fe18ba4a7c3c146fb34478a27b14c0e8e25f40606a2ec29fd239ab6d6112

OS/Platform Previous Size Current Size Delta
linux/amd64 432.86M 432.86M 1.55K (+0.00%)
linux/arm64 572.09M 572.09M 664.00 (+0.00%)

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:8dc1e7c187f2880e6d2745a8a654df391206dd63f2b222d409a48e5fdc377e43

OS/Platform Previous Size Current Size Delta
linux/amd64 640.66M 640.66M 2.30K (+0.00%)
linux/arm64 633.02M 633.02M 1.81K (+0.00%)

Copy link
Contributor

github-actions bot commented Jul 2, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 15 0 0.05s
✅ DOCKERFILE hadolint 2 0 0.53s
✅ JSON prettier 11 0 0 0.59s
✅ JSON v8r 10 0 4.29s
✅ MARKDOWN markdownlint 8 0 0 0.96s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.21s
✅ REPOSITORY checkov yes no 16.97s
✅ REPOSITORY gitleaks yes no 0.31s
✅ REPOSITORY git_diff yes no 0.02s
✅ REPOSITORY grype yes no 14.08s
✅ REPOSITORY secretlint yes no 1.45s
✅ REPOSITORY trivy yes no 7.93s
✅ REPOSITORY trivy-sbom yes no 3.5s
✅ REPOSITORY trufflehog yes no 3.54s
✅ SPELL lychee 48 0 1.82s
✅ YAML prettier 20 0 0 0.92s
✅ YAML v8r 20 0 12.8s
✅ YAML yamllint 20 0 0.46s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Jul 2, 2024

Test Results

 2 files  ±0   2 suites  ±0   56s ⏱️ +6s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 29475bc. ± Comparison against base commit 02df97e.

♻️ This comment has been updated with latest results.

@rjaegers rjaegers enabled auto-merge July 2, 2024 11:54
@magi-arun magi-arun requested a review from EkelmansPh July 4, 2024 07:21
@rjaegers rjaegers added this pull request to the merge queue Jul 4, 2024
@rjaegers rjaegers removed this pull request from the merge queue due to a manual request Jul 4, 2024
Copy link

sonarqubecloud bot commented Jul 4, 2024

@rjaegers rjaegers enabled auto-merge July 4, 2024 09:10
@rjaegers rjaegers added this pull request to the merge queue Jul 4, 2024
Merged via the queue into main with commit 20e6d49 Jul 4, 2024
17 checks passed
@rjaegers rjaegers deleted the feature/remove-duplication-in-test-code branch July 4, 2024 14:24
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Pull Request Report (#482)

Static measures

Description Value
Number of added lines 33
Number of deleted lines 84
Number of changed files 3
Number of commits 2
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 2.2 Days
Time that was spend on the branch before the PR was created 1.4 Min
Time that was spend on the branch before the PR was merged 2.2 Days
Time to merge after last review 5.3 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 11.8 Min
Total time spend in last status check run on PR 3.5 Min

Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.1.3 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants