Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add end-to-end tests with Playwright #516

Merged
merged 57 commits into from
Aug 28, 2024
Merged

test: add end-to-end tests with Playwright #516

merged 57 commits into from
Aug 28, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Jul 24, 2024

Pull Request

Description of changes

This PR adds an end-to-end test for the cpp devcontainer to try out running (smoke) tests for the full container experience including the extensions and the front-end.

The technical implementation is done by starting a GitHub Codespace with the container that is currently being built by the PR (communicated as a Codespace secret) and running Playwright tests against that Codespace instance.

Changed the interval of Dependabot updates from daily to weekly.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:34b958e4b9ec7737b829bce86fa6ef57223fdefeb325531c4fc272af0d493ff4

OS/Platform Previous Size Current Size Delta
linux/amd64 640.74M 641.13M 395.09K (+0.06%)
linux/arm64 633.10M 633.48M 384.73K (+0.06%)

Copy link
Contributor

github-actions bot commented Jul 24, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.07s
✅ DOCKERFILE hadolint 2 0 0.33s
✅ JSON prettier 15 0 0 0.63s
✅ JSON v8r 14 0 18.49s
✅ MARKDOWN markdownlint 8 0 0 1.02s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.24s
✅ REPOSITORY checkov yes no 16.99s
✅ REPOSITORY gitleaks yes no 0.22s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.11s
✅ REPOSITORY secretlint yes no 1.3s
✅ REPOSITORY trivy yes no 6.02s
✅ REPOSITORY trivy-sbom yes no 0.9s
✅ REPOSITORY trufflehog yes no 3.02s
✅ SPELL lychee 54 0 1.59s
✅ YAML prettier 21 0 0 1.0s
✅ YAML v8r 21 0 13.57s
✅ YAML yamllint 21 0 0.37s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:ca052e99846ada8aac5c3e77e9753499d6f9b76cb7dbfea87f1375581450da8a

OS/Platform Previous Size Current Size Delta
linux/amd64 432.86M 433.15M 304.42K (+0.07%)
linux/arm64 572.09M 572.36M 278.83K (+0.05%)

Copy link
Contributor

github-actions bot commented Jul 24, 2024

Test Results

 2 files  ±0   2 suites  ±0   50s ⏱️ -2s
26 tests ±0  26 ✅ ±0  0 💤 ±0  0 ❌ ±0 
28 runs  ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 825c320. ± Comparison against base commit 41abe95.

♻️ This comment has been updated with latest results.

@rjaegers rjaegers marked this pull request as ready for review July 31, 2024 15:19
@rjaegers rjaegers requested a review from a team as a code owner July 31, 2024 15:19
@rjaegers rjaegers requested a review from npalm August 27, 2024 09:13
Copy link

@rjaegers rjaegers added this pull request to the merge queue Aug 28, 2024
Merged via the queue into main with commit 69d9ce8 Aug 28, 2024
18 checks passed
@rjaegers rjaegers deleted the feature/e2e-tests branch August 28, 2024 12:27
Copy link
Contributor

Pull Request Report (#516)

Static measures

Description Value
Number of added lines 509
Number of deleted lines 5
Number of changed files 16
Number of commits 57
Number of reviews 2
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 6

Time related measures

Description Value
PR lead time (from creation to close of PR) 35.1 Days
Time that was spend on the branch before the PR was created 1.1 Hours
Time that was spend on the branch before the PR was merged 35.2 Days
Time to merge after last review 27.2 Days

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 16.5 Min
Total time spend in last status check run on PR 8 Min

Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.1.4 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants