Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add conan package manager to amp-devcontainer-cpp #607

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Oct 19, 2024

Pull Request

Description of changes

This PR adds support for the Conan package manager to amp-devcontainer-cpp.

See this roundup for a comparison of C++ package managers.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner October 19, 2024 13:28
Copy link
Contributor

github-actions bot commented Oct 19, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:e92916bf6747fd6f3fb8950335003df6fd726a538dc29cf3787aa25d67cad91c

OS/Platform Previous Size Current Size Delta
linux/amd64 425.13M 433.00M 7.87M (+1.85%)
linux/arm64 564.77M 572.52M 7.75M (+1.37%)

Copy link
Contributor

github-actions bot commented Oct 19, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.05s
✅ DOCKERFILE hadolint 2 0 0.41s
✅ GHERKIN gherkin-lint 2 0 0.76s
✅ JSON npm-package-json-lint yes no 0.48s
✅ JSON prettier 15 2 0 0.8s
✅ JSON v8r 14 0 17.3s
✅ MARKDOWN markdownlint 8 0 0 1.03s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.26s
✅ REPOSITORY checkov yes no 18.16s
✅ REPOSITORY gitleaks yes no 0.59s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 13.29s
✅ REPOSITORY secretlint yes no 1.72s
✅ REPOSITORY syft yes no 0.45s
✅ REPOSITORY trivy yes no 28.07s
✅ REPOSITORY trivy-sbom yes no 0.17s
✅ REPOSITORY trufflehog yes no 2.77s
✅ SPELL lychee 58 0 1.2s
✅ YAML prettier 21 0 0 1.14s
✅ YAML v8r 21 0 17.07s
✅ YAML yamllint 21 0 0.43s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Oct 19, 2024

Test Results

 2 files  ±0   2 suites  ±0   1m 11s ⏱️ +13s
28 tests +1  28 ✅ +1  0 💤 ±0  0 ❌ ±0 
30 runs  +1  30 ✅ +1  0 💤 ±0  0 ❌ ±0 

Results for commit c0336fb. ± Comparison against base commit e73794d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 19, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:734144897ac1261dd612a9fff5f747adc296b1279cacd069cc028744753ddd40

OS/Platform Previous Size Current Size Delta
linux/amd64 645.35M 650.42M 5.07M (+0.79%)
linux/arm64 638.06M 643.10M 5.04M (+0.79%)

Copy link

@rjaegers rjaegers added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit e142e40 Oct 22, 2024
22 checks passed
@rjaegers rjaegers deleted the feature/add-conan-package-manager branch October 22, 2024 13:33
Copy link
Contributor

Pull Request Report (#607)

Static measures

Description Value
Number of added lines 259
Number of deleted lines 14
Number of changed files 10
Number of commits 8
Number of reviews 2
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 1
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 3 Days
Time that was spend on the branch before the PR was created 1 Min
Time that was spend on the branch before the PR was merged 3 Days
Time to merge after last review 5.3 Hours

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 21.2 Min
Total time spend in last status check run on PR 9.1 Min

Copy link
Contributor

🎉 Hooray! The changes in this pull request went live with the release of v5.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants