Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: move tests to top-level out of the devcontainer folder #624

Merged
merged 15 commits into from
Nov 6, 2024

Conversation

rjaegers
Copy link
Member

@rjaegers rjaegers commented Oct 30, 2024

Pull Request

Description of changes

This PR pulls up the tests to the root of the repository, out of the .devcontainer folder.

There are several benefits to this approach:

  • SonarQube will be able to find the test files, as all folders starting with a "dot" are ignored.
  • The tests will be more front-and-center, which is more important as the end-to-end test BDD scenarios grow.
  • It creates a cleaner separation of concern, the .devcontainer folder only contains devcontainer content now.

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@rjaegers rjaegers requested a review from a team as a code owner October 30, 2024 12:56
Copy link
Contributor

github-actions bot commented Oct 30, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:1531c82e9dd6b2dada3ed02366fd197896161526d70cad47a7f1c0a63339d7e1

OS/Platform Previous Size Current Size Delta
linux/amd64 433.00M 459.82M 26.82M (+6.19%)
linux/arm64 572.52M 599.31M 26.80M (+4.68%)

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:78d092dde2945be185489a87313b251d8b939d8c42341aab3f3fd481d9b6f239

OS/Platform Previous Size Current Size Delta
linux/amd64 650.42M 650.48M 57.71K (+0.01%)
linux/arm64 643.10M 643.16M 62.00K (+0.01%)

Copy link
Contributor

github-actions bot commented Oct 30, 2024

Test Results

 2 files  ±0   2 suites  ±0   1m 22s ⏱️ +8s
29 tests ±0  29 ✅ ±0  0 💤 ±0  0 ❌ ±0 
31 runs  ±0  31 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 322215f. ± Comparison against base commit 252fab6.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Oct 30, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.06s
✅ DOCKERFILE hadolint 2 0 0.39s
✅ GHERKIN gherkin-lint 2 0 0.64s
✅ JSON npm-package-json-lint yes no 0.42s
✅ JSON prettier 15 1 0 0.72s
✅ JSON v8r 14 0 18.06s
✅ MARKDOWN markdownlint 8 0 0 0.96s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.24s
✅ REPOSITORY checkov yes no 18.69s
✅ REPOSITORY gitleaks yes no 0.32s
✅ REPOSITORY git_diff yes no 0.01s
✅ REPOSITORY grype yes no 15.15s
✅ REPOSITORY secretlint yes no 1.46s
✅ REPOSITORY syft yes no 0.43s
✅ REPOSITORY trivy yes no 26.43s
✅ REPOSITORY trivy-sbom yes no 0.08s
✅ REPOSITORY trufflehog yes no 2.08s
✅ SPELL lychee 57 0 1.25s
✅ YAML prettier 21 0 0 1.07s
✅ YAML v8r 21 0 15.47s
✅ YAML yamllint 21 0 0.41s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

@magi-arun magi-arun requested a review from EkelmansPh October 31, 2024 08:16
Copy link

sonarqubecloud bot commented Nov 6, 2024

@rjaegers rjaegers added this pull request to the merge queue Nov 6, 2024
Merged via the queue into main with commit 92ea3e3 Nov 6, 2024
24 checks passed
@rjaegers rjaegers deleted the feature/refactor-test-layout branch November 6, 2024 10:56
Copy link
Contributor

github-actions bot commented Nov 6, 2024

Pull Request Report (#624)

Static measures

Description Value
Number of added lines 110
Number of deleted lines 125
Number of changed files 72
Number of commits 15
Number of reviews 1
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 1
Get the total number of participants of a Pull Request 4

Time related measures

Description Value
PR lead time (from creation to close of PR) 6.9 Days
Time that was spend on the branch before the PR was created 5.6 Min
Time that was spend on the branch before the PR was merged 6.9 Days
Time to merge after last review 5.1 Days

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 20.9 Min
Total time spend in last status check run on PR 8.9 Min

Copy link
Contributor

github-actions bot commented Nov 7, 2024

🎉 Hooray! The changes in this pull request went live with the release of v5.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants