Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add udev to amp-devcontainer-rust #626

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Conversation

richardapeters
Copy link
Contributor

@richardapeters richardapeters commented Oct 31, 2024

Pull Request

Description of changes

Checklist

  • I have followed the contribution guidelines for this repository
  • I have added tests for new behavior, and have not broken any existing tests
  • I have added or updated relevant documentation
  • I have verified that all added components are accounted for in the SBOM

@richardapeters richardapeters requested a review from a team as a code owner October 31, 2024 13:41
Copy link

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-cpp:latest to ghcr.io/philips-software/amp-devcontainer-cpp@sha256:1bf75c94c2cf98256af14f5f10f3e4a72f2b59f54f8a1f76ede5f3f5f4a1a61d

OS/Platform Previous Size Current Size Delta
linux/amd64 650.42M 650.42M 0.00 (+0.00%)
linux/arm64 643.10M 643.10M 0.00 (+0.00%)

Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 16 0 0.07s
✅ DOCKERFILE hadolint 2 0 0.48s
✅ GHERKIN gherkin-lint 2 0 0.71s
✅ JSON npm-package-json-lint yes no 0.46s
✅ JSON prettier 15 2 0 0.73s
✅ JSON v8r 14 0 18.77s
✅ MARKDOWN markdownlint 8 0 0 0.94s
✅ MARKDOWN markdown-table-formatter 8 0 0 0.23s
✅ REPOSITORY checkov yes no 17.68s
✅ REPOSITORY gitleaks yes no 0.74s
✅ REPOSITORY git_diff yes no 0.04s
✅ REPOSITORY grype yes no 12.88s
✅ REPOSITORY secretlint yes no 1.52s
✅ REPOSITORY syft yes no 0.66s
✅ REPOSITORY trivy yes no 6.63s
✅ REPOSITORY trivy-sbom yes no 0.14s
✅ REPOSITORY trufflehog yes no 9.54s
✅ SPELL lychee 58 0 2.11s
✅ YAML prettier 21 0 0 1.05s
✅ YAML v8r 21 0 16.66s
✅ YAML yamllint 21 0 0.45s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Test Results

 2 files  ±0   2 suites  ±0   1m 9s ⏱️ -1s
28 tests ±0  28 ✅ ±0  0 💤 ±0  0 ❌ ±0 
30 runs  ±0  30 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 2c1e6f3. ± Comparison against base commit 09fe055.

Copy link
Contributor

Compressed layer size comparison

Comparing ghcr.io/philips-software/amp-devcontainer-rust:latest to ghcr.io/philips-software/amp-devcontainer-rust@sha256:1b4333247623dd0f2629b1b6ba5ac38ff826d1120e351a7455bc513dee731a68

OS/Platform Previous Size Current Size Delta
linux/amd64 433.00M 443.60M 10.61M (+2.45%)
linux/arm64 572.52M 583.12M 10.60M (+1.85%)

@BarisTanyeri BarisTanyeri requested a review from rjaegers November 1, 2024 08:21
@richardapeters richardapeters added this pull request to the merge queue Nov 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2024
@daantimmer daantimmer added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit c0ae629 Nov 1, 2024
25 checks passed
@daantimmer daantimmer deleted the feature/udev-rust branch November 1, 2024 09:39
Copy link
Contributor

github-actions bot commented Nov 1, 2024

Pull Request Report (#626)

Static measures

Description Value
Number of added lines 1
Number of deleted lines 0
Number of changed files 1
Number of commits 1
Number of reviews 2
Number of comments (w/o review comments) 5
Number of reviews that contains a comment to resolve 0
Number of reviews that requested a change from the author 0
Number of reviews that approved the Pull Request 2
Get the total number of participants of a Pull Request 5

Time related measures

Description Value
PR lead time (from creation to close of PR) 20 Hours
Time that was spend on the branch before the PR was created 22 Sec
Time that was spend on the branch before the PR was merged 20 Hours
Time to merge after last review 8.1 Min

Status check related measures

Description Value
Total runtime for last status check run (Workflow for PR) 35.5 Min
Total time spend in last status check run on PR 20.3 Min

Copy link
Contributor

github-actions bot commented Nov 7, 2024

🎉 Hooray! The changes in this pull request went live with the release of v5.5.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants