Support changing of the video source

[philipwatson]

In progress.

When the video source is changed, the plugin will request the vast (or use the provided vast xml) and start the ad workflow again.

You shouldn't change the source during the ad break because contrib-ads doesn't support this case. For example, should do something like this:

if (!player.ads.isInAdMode()) {
   // then should be ok to change source
} 

But not sure if this will be enough. So added support for changing source during ad playback - might disable this by default (have to enable via config)... though not sure about this yet.

Other things I need to think about or do:

• ability to change the vast XML
• ability to change the vast URL
• ability to change the ad schedule
• ability to cancel upcoming ads (ad schedule) so user can safely change source
• is it safe to change content source in ad mode (when player.ads.inAdBreak() is false)?
• test live stream and vpaid

[nachoaguirre]

cool! great news

I've been fighting some bugs too, but my case is worse, since I'm integrating a plugin for Peertube (a YouTube clone, more or less), and it works as a SPA, so it's harder to intercept events... all the page changes, video started, finished, etc, everything is asynchronous... Terrible for me hehe

I have some improvements that you could try if you like and integrate them (I'd love to do it but I don't have time)

• some browsers (like FF) are throwing buffer problems, i fixed this adding the following in videojs.ads.min.js

player.on('loadstart', checkSrc);
window.setTimeout(checkSrc, 1);

I invite you to try it and if you see that it improves something, it could be integrated hehe

---

I noticed that in some cases when an ad is playing, the play icon was not being displayed... I fixed it like this in ui.mjs

updateState: (button, player) => {
    button.removeClass('vjs-icon-play');
    button.removeClass('vjs-icon-pause');
    button.addClass(player.paused() ? 'vjs-icon-play' : 'vjs-icon-pause');
}

---

A little further down, in the destructuring of config[] added updateState
const { className, action, toggleClasses, events, initialState, updateState } = config[type];

---

further down the toggleIcon was changed to:

const toggleIcon = () => {
        if (updateState) {
          updateState(button, player);
        } else {
          toggleClasses.forEach(cls => button.toggleClass(cls));
        }
      };

[philipwatson]

@nachoaguirre Thank you for your feedback. Will look into them when I find the time. Currently addressing VPAID issues at the moment.