Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse support using wheel and buttons #208

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

marc24force
Copy link

I have added mouse support (#43) to select an entry using the wheel, confirm with left click and cancel with right click.
This feature is disabled by default unless the setting mouse-enable is set to true.

@marc24force marc24force mentioned this pull request Dec 27, 2024
@bricewge
Copy link

It works as intend with a mouse, to select, close or submit. But it does not work with scrolling gesture as I was wrongly expected.

I have doubt about the naming of the option to mouse-enable when compared to the other options. For example history or text-cursor aren't suffixed with -enable even tho that's they enable a feature. IMHO having it named mouse would look more consistent in regard to the existing options.

@marc24force
Copy link
Author

marc24force commented Dec 28, 2024

It works as intend with a mouse, to select, close or submit. But it does not work with scrolling gesture as I was wrongly expected.

I don't have any gesture device to test it. If someone can implement it and test it I can do a merge.

I have doubt about the naming of the option to mouse-enable when compared to the other options. For example history or text-cursor aren't suffixed with -enable even tho that's they enable a feature. IMHO having it named mouse would look more consistent in regard to the existing options.

Good point, done

@marc24force marc24force changed the title Mouse support using mouse and wheel Mouse support using wheel and buttons Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants