Fix: Assignment operator typo in filter_clones.R#2
Open
eos-jin wants to merge 1 commit into
Open
Conversation
…ined_clones The bug on line 54 used '<' (comparison) instead of '<-' (assignment) when handling the edge case where no clones meet the threshold without grouping. This caused n_clones to not be properly assigned, leading to incorrect behavior when all values are below the threshold. This fix ensures that zero counts are correctly returned when no data passes the threshold filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in
R/filter_clones.Rwhere a comparison operator<was used instead of assignment<-.The Bug
Impact
This bug caused the
filter_clones()function to silently fail to assign the filtered result.Testing
All 16 existing filtering tests pass after the fix.
Context
Identified during code review for the NextClone paper revision.