Repository navigation
style(editor): wash the selection so a dragged range is visible - #10
Merged
Merged
Conversation
`npm run dev:bundled` without a PORT fell back to 5173, the same port as `npm run dev`, so running both needed an explicit --port. Vite's preview default (4173) keeps the two side by side out of the box.
The selection was an outline only, which made a large range hard to see while dragging it. Selected cells now carry a translucent accent wash under the outline, so the range reads as a block as it grows; text stays readable through it and the fill handle is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the UI v2 stack: two commits were made just after #8 was merged, so they never reached
main. This PR brings them over unchanged.style(editor): wash the selection so a dragged range is visible— the selection overlay keeps its two-pixel accent outline and now also fills with the accent at 15%, so a dragged range reads as one block instead of a hairline rectangle. Mapped-field overlays, the fill handle and the version-diff colours are untouched.docs(editor): default the bundled dev server to port 4173—npm run dev:bundledfell back to 5173, the same port asnpm run dev; Vite's preview default keeps the two side by side without an explicit--port.Verified:
npm test(144 passed),npx tsc -b,npm run lint, and a drag ofA2:C6in the running build shows the wash in both themes (overlay computes tooklab(... / 0.15)over the accent outline).