Repository navigation
fix(editor): stop section bands becoming tables and list fields - #12
Merged
Merged
Conversation
Worksheet forms title each section with a merged band such as "Supplementary Pages" or "Equipment". When the row underneath held a single label and a status value, the scan read the band as a table header and proposed a table over the section, and it also read the band as the label of a list field over the section's own row labels. A run that is one merged region is now treated as a section title: it never becomes a table header, and it never starts a range field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why the change
Worksheet forms title each section with a merged band such as "Supplementary Pages" or "Equipment", and the scan read those bands as data: as a table header over the section, or as the label of a list field over the section's own row labels.
Special things to note
Change outline
Two guards, both keyed on the same shape: a run of cells that is one merged region is a title, not data.
The section band that used to be read as a header row, in the reported shape:
editor/src/ └── lib/ ├── suggestions.ts # isSectionBand guard in the table and range paths └── suggestions.test.ts # 2 new cases: band as header, band as list label