Build assets on CI and add caching #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
💚 💙 💜 💛 ❤️ |
|
@chrismccord @josevalim should we do the same for LiveView? |
|
@SteffenDE I think that would make sense, LV is even more likely to be installed from GitHub, so having the assets in sync is good. I opened a PR phoenixframework/phoenix_live_view#3552 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently assets need to be built manually, which can be forgotten. Also, sometimes non-minified dist is merged in PRs. This adds a workflow to automatically build the assets (particularly useful when installing phoenix_live_dashboard directly from github).
I also added caching to the existing workflow for faster builds.
I tested that both workflows work on the fork :)