Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

#2703 IOS: Missing Push Notification Entitlement #2704

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

regevbr
Copy link

@regevbr regevbr commented Feb 11, 2019

add missing entitlements

Description

add missing entitlements

Related Issue

#2703

Motivation and Context

Fixes release issue of ios apps

How Has This Been Tested?

Uploaded build to ios without manualy adding the push entitlement in xcode

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@ankon
Copy link

ankon commented Feb 19, 2019

I see that in #2703 you suggest to use 'production', while the PR uses 'development'. Is this something that a developer would have to switch around? If so probably documentation is needed for this change.

@regevbr
Copy link
Author

regevbr commented Feb 19, 2019

It should stay developed due to xcode bugs from what I found

@tobeycodes
Copy link

@regevbr Do you have any idea why this happens on one of my apps but not the other?

There must be a way to do this without hardocoding the development/production string value or at least determine where the conflict comes from.

@regevbr
Copy link
Author

regevbr commented Mar 5, 2019

Sorry, no idea... Maybe one of the developers can answer that?

@yeliu84
Copy link

yeliu84 commented Mar 6, 2019

@regevbr Can you confirm this issue is due to Xcode, not due to cordova/cordova-ios/push-plugin?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants