This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
enable automatic permission request by user for notifications when ch… #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eckpermission called
GitToTheHub
reviewed
Nov 1, 2019
| [self.commandDelegate sendPluginResult:commandResult callbackId:command.callbackId]; | ||
| }]; | ||
| }else{ | ||
| NSMutableDictionary* message = [NSMutableDictionary dictionaryWithCapacity:1]; |
There was a problem hiding this comment.
Maybe you should try to avoid dublicate code, because these 4 lines are the same if already granted or the completionHandler is called.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable automatic permission request by user for notifications when checkpermission called
Description
First we have to request notification permission from user. Without this you cannot send notifications.
I had to use localnotifications plugin to request permissions but because of that the push.on('registration',) did not fired on ios when app in foreground.
issue: #2222
This is a solution for this:
#2085
Related Issue
#2085
Motivation and Context
I had to use localnotifications plugin to request permissions but because of that the push.on('registration',) did not fired on ios when app in foreground.
How Has This Been Tested?
Screenshots (if appropriate):
https://i1.wp.com/www.simplifiedios.net/wp-content/uploads/2018/01/iOS-Local-Notification-Authorization.png?w=399&ssl=1
Types of changes
Checklist: