This repository has been archived by the owner on Sep 4, 2020. It is now read-only.
✨ 🐧 Allow implementation of a user invitation to fix settings #2848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h Importance and SoundUri values to allow implementation of a user invitation to fix settings: https://developer.android.com/training/notify-user/channels#UpdateChannel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added OPEN_NOTIFICATIONS_SETTINGS intent trigger method along with Importance and SoundUri values to allow implementation of a user invitation to fix settings:
https://developer.android.com/training/notify-user/channels#UpdateChannel
Related Issue
#2847
Motivation and Context
In our own project, we need to be able to open Intent related to Channel settings.
Please see https://developer.android.com/training/notify-user/channels#UpdateChannel
for more details over this need.
How Has This Been Tested?
Tested in our project, not sure how we should proceed for testing. Could be Spy call checks like existing methods, however I have noticed some methods are untested. Due to it's Android only nature.
Screenshots (if appropriate):
Types of changes
[x] New feature (non-breaking change which adds functionality)
Checklist: