Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

[DRAFT] feat: remove cordova-support-google-services dependency #2873

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[DRAFT] feat: remove cordova-support-google-services dependency #2873

wants to merge 1 commit into from

Conversation

erisu
Copy link
Collaborator

@erisu erisu commented Jan 15, 2020

Description

Removes the cordova-support-google-services dependency

Related Issue

Issue will be created at a later time. This PR is current set to draft and will not be ready to merge until Cordova Android release.

Motivation and Context

The next version of Cordova Android will have preference options to enable Google Services and the ability to define which versions of Google Services to use.

With this new feature, having this plugin inject to the into the Gradle build process causes build failures. This dependency will no longer be needed.

How Has This Been Tested?

  • Created a new Cordova project with CLI 9
  • Added new feature branch of Cordova Android with preference options.
  • Added Plugin
  • Ran Cordova build

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

Will review each item and update accordingly before PR is open from draft mode.

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@erisu erisu added this to the Release 3.0.0 milestone Jan 15, 2020
@erisu erisu changed the title feat: remove cordova-support-google-services dependency [DRAFT] feat: remove cordova-support-google-services dependency Jan 15, 2020
@shankari
Copy link

Is there an ETA for this merge? [email protected] has already released

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants