Skip to content
This repository has been archived by the owner on Sep 4, 2020. It is now read-only.

(ios) pass data to on('notification') while app is in foreground #2907

Open
wants to merge 45 commits into
base: master
Choose a base branch
from

Conversation

duca14036
Copy link

Update support of latest Firebase/Messaging
Receive push data while app is in foreground

Description

Update IF condition in case if app is in foreground to pass data and receive inside on('notification')

Related Issue

Issue: #2783

Motivation and Context

Receiving push while app is in foreground is also important

How Has This Been Tested?

Send push notification using suggested payload from docs

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

duca14036 and others added 30 commits July 23, 2019 22:32
updated firebase
register for push notification like in FCM doc
* Updated Documentation for Critical Alerts
* Added Initializiation Parameter "critical" for iOS Critical Alerts (Possible since iOS 12.0) (Special Entitlement required!)

Co-authored-by: Holger Martiker <[email protected]>
…honegap#13)

Notifications should persist when the app is moved to the background in order to draw the user back to re-activate the app when they are done multitasking.

Notifications should be destroyed when the all is closed though to avoid clutter.

Co-authored-by: Gaven Henry <[email protected]>
* feat(android): bump fcm@18.+
* docs: include FMC_VERSION support notice
* docs: correct FCM_VERSION acceptable range

Co-authored-by: jcesarmobile <[email protected]>
* chore(android): update editor config rules
* chore(android): apply formatting editor config formatting
* chore(android): remove unused imports
* doc(contributing): improve text & formatting
* chore(issue-templates): update & improve
* docs(contributing): apply markdown format
jgmdev and others added 15 commits September 10, 2020 10:16
* Changes which allow data to be passed to app when tapping notification
* Fixed typo
* Reverted changes to PushHandlerActivity and created a new Activity to handle the new functionality.
* Updated the documentation
* Fixed missing quotation marks
* chore: reformat new android src file
* chore: remove unused variable declaration
* chore: fix typo

Co-authored-by: Silviu Ion <[email protected]>
Co-authored-by: Moghul <[email protected]>
* doc: cleanup docs
* doc: remove old minSdkVersion 14 common error
* doc: Update docs/INSTALLATION.md
* doc(android): remove compilation about old support library
* doc: update readme

Co-authored-by: jcesarmobile <[email protected]>
* commit 'd7932274652ca2f977c67580b1dcbf1ed22fa878': (33 commits)
  fix(android): missing channel description crash (phonegap#53)
  doc(android): enable & set notification light with lightColor (phonegap#54)
  chore(android): set requirement >= 8.0.0 (phonegap#52)
  doc: cleanup docs (phonegap#51)
  fix(android): Use app name for default channel (phonegap#49)
  feat(ios): increase firebase framework to 6.32.2 (phonegap#42)
  chore(npm): properly configure for scope package (phonegap#33)
  feature: android notification data pass (phonegap#31)
  fix(browser): corrected path to manifest file. (phonegap#32)
  doc: update various markdown docs (phonegap#28)
  chore(android): cleanup & format (phonegap#26)
  core(ios): use latest firebase library (phonegap#24)
  chore: update ticket management (phonegap#27)
  breaking(android): bump fcm@18.+ (phonegap#19)
  chore: add missing build of push.js (phonegap#22)
  ci(gh-actions): add workflow (phonegap#23)
  chore(android): bump com.android.support:support-v13:28.0.0 (phonegap#20)
  breaking(android): drop phonegap-plugin-multidex dependency (phonegap#21)
  fix(android): enable lights when lightColor is set (phonegap#15)
  chore(type-definition): Update PushNotificationStatic (phonegap#14)
  ...

# Conflicts:
#	package.json
#	plugin.xml
#	src/ios/PushPlugin.m
* commit '79333b25e1ff68fea377be499da91528c82fa21f':
  fix: incorrect initial cordova-cli requirement
  chore: bump version to 1.0.1-dev.0
  release(1.0.0): version & changelog
  chore(npm): rebuilt package-lock.json (phonegap#55)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants