Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): updated version of phpunit and fixed workflow issues #17

Merged
merged 2 commits into from
May 26, 2024

Conversation

Dobmod
Copy link
Member

@Dobmod Dobmod commented May 25, 2024

Replaced the old Travis CI badge with GitHub Actions CI badge in README.md, and all unit tests in the workflow were all green, but I am unable to test the issues that occurred on the 'release'.😁

Copy link
Member

@leeqvip leeqvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the node version for github actions

@Dobmod Dobmod requested a review from leeqvip May 25, 2024 13:51
"config": {
"allow-plugins": {
"yiisoft/yii2-composer": true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I have tested it.
If not, during the 'composer install' process, a confirmation option about yii2-composer installation appears,and the workflow will be red. 😯

@leeqvip leeqvip changed the title perf: updated version of phpunit and fixed workflow issues fix(ci): updated version of phpunit and fixed workflow issues May 26, 2024
@leeqvip leeqvip merged commit c8cb31b into php-casbin:master May 26, 2024
15 checks passed
@leeqvip
Copy link
Member

leeqvip commented May 26, 2024

🎉 This PR is included in version 1.5.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants