Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced factory with loop::get() as factory depreciated. #48

Merged
merged 10 commits into from
Oct 20, 2021
Merged

Replaced factory with loop::get() as factory depreciated. #48

merged 10 commits into from
Oct 20, 2021

Conversation

tolgaulas
Copy link
Contributor

Fixes #47

dbu
dbu requested changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot for this cleanup!

i have some details and please separate the cancel method topic out of this PR so that we can merge the update.

@tolgaulas
Copy link
Contributor Author

@dbu, i made the changes, i think its good to go.

dbu
dbu approved these changes Oct 20, 2021
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

dbu
dbu reviewed Oct 20, 2021
View reviewed changes
dbu
dbu reviewed Oct 20, 2021
View reviewed changes
@dbu dbu merged commit 3d701ee into php-http:master Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

evetnloop:factory is depreciated, replaced with loop:get()
2 participants
@tolgaulas @dbu