Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some funky string juggling for the never/void return type handling #245

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

johnbillion
Copy link
Contributor

No functional change, just some cleaner code.

@szepeviktor
Copy link
Member

❌🤹

@szepeviktor szepeviktor merged commit 1484a81 into php-stubs:master Oct 5, 2024
5 checks passed
@szepeviktor
Copy link
Member

Thank you, John.

@IanDelMar
Copy link
Contributor

Thank you! I’m about to move the void or never check out of the Visitor class into a helper class. I will check whether this will re-add anything you’ve just refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants