Conditionally add return type for WP_Http::request

[IanDelMar]

Removes duplicate return tag for WP_Http::request()

[szepeviktor]

Hello guys!
This has turned into a wrong direction.

How to handle ever-growing number of PHPStan tags in core???

[szepeviktor]

How about not adding a tag that already exists?
Could we do that?
(and write a log line)

[IanDelMar]

We can. But then it is lost for each previous version as well.

[szepeviktor]

But then it is lost for each previous version as well.

Why? I do not understand.

Only not add our tag when one already exists in the current version.

[IanDelMar]

Ah, you mean not adding a tag if the visitor added a tag automatically? We can avoid it that way, but at the cost of losing the ability to override incorrect tags that were added automatically.

[szepeviktor]

to override incorrect tags that were added automatically.

That is better!

So if there is already a @phpstan-* tag in core we overwrite that: core's tag will be removed, not ours.

[szepeviktor]

core's tag will be removed, not ours.

The opposite of this PR.

[IanDelMar]

Not sure what you mean by

So if there is already a @phpstan-* tag in core we overwrite that: core's tag will be removed, not ours.

There is no @phpstan-* tag in core. They are all generated by the visitor.

As far as I can tell, in the case of WP_Http::request, the auto-generated tag is more accurate than the one generated from functionMap.php.

[szepeviktor]

I see!!

"Autogenerated" means we read @return { @type ... } and autogenerate a phpstan tag.

Okay. Then drop the one from functionMap.php.

[szepeviktor]

but no $wp_version please

[IanDelMar]

Okay. Then drop the one from functionMap.php.

That's what I did. We can implement the same behavior via the visitor, but I won't have time for this this week.

[IanDelMar]

#265