-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] Deprecate extract, upload, and download commands before 1.0 #446
Comments
I think it's a good idea. I don't think we want to duplicate the functionality, so, we can deprecate the code that was already implemented in Symfony, and later drop the deprecated code when we will drop support for Symfony <5.3 IMO |
Maybe create an overview / comparison of all functionality first? Or are the Symfony implementations functionally identical to the ones in this bundle? |
I became curious also how the translation functionality will evolve further. |
@elfring which command implementation do you refer? |
Example: update or extract |
If you talk about commands in php-translation/symfony-bundle, there will no more commands here, we will consider Symfony's one as enough stable to use them. For update/extract command, see symfony/symfony#41411 |
Will any more extensions be reconsidered for this software area? 🤔 |
Like what? I suggest to remove all double features between this bundle and Symfony, but keeping what's existing only in the bundle (EditInPlace, Web UI, and improved translation Profiler panel) |
Some issues will trigger further development considerations, won't they? 🤔 |
You point issues on Symfony, not on php-translation bundle, so I don't understand what you want to explain? |
I assumed (for example) that the bundled extract command was improved in comparison to the Symfony update command. |
We plan to move improvements of extract command of the bundle to Symfony, if it's possible. If not, we will keep the extract command in the bundle (maybe renamed, to avoid conflicts with the Symfony one) |
As Symfony 5.3 brings Translation Providers, which are the native equivalent of Adapters here, I wonder to deprecate them and thus the associated commands (+ extract, which also could be merged with the Symfony one, see symfony/symfony#41411).
After Adapters and commands removal, the bundle keeps a reason to live, because of the improved Translation Panel in Profiler will never be accepted in Symfony's core, and the edit-in-place feature which are both taking there place here, in an external bundle.
My point is to remove all duplicated features with Symfony from the bundle, and keeps what will belongs to the bundle only, then we could plan a 1.0 version.
Please @php-translation/deciders and @php-translation/members give me your thoughts about that 🙏
The text was updated successfully, but these errors were encountered: