Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove symfony console $defaultName deprecation #491

Merged
merged 4 commits into from
Jul 11, 2023
Merged

Remove symfony console $defaultName deprecation #491

merged 4 commits into from
Jul 11, 2023

Conversation

axi
Copy link
Contributor

@axi axi commented Jul 5, 2023

@axi
Copy link
Contributor Author

axi commented Jul 5, 2023

image
I don't get why those tests are still required

bocharsky-bw
bocharsky-bw reviewed Jul 6, 2023
View reviewed changes
Copy link
Member

@bocharsky-bw bocharsky-bw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sounds like a good fit for a new 0.14.0 release?

I don't get why those tests are still required

Not a problem, those are just required in the repo config - I can change it when this PR will be merged.

@bocharsky-bw
Copy link
Member

OK, merging, thank you for handling this!

@bocharsky-bw bocharsky-bw merged commit d930db6 into php-translation:master Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bocharsky-bw bocharsky-bw bocharsky-bw approved these changes

@rvanlaak rvanlaak rvanlaak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecation: The "Symfony\Component\Console\Command\Command::$defaultName" property is considered final
3 participants
@axi @bocharsky-bw @rvanlaak