Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 8.3, 8.4 to CI #505

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Add PHP 8.3, 8.4 to CI #505

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bd0917
Add PHP 8.3, 8.4 to CI
andreybolonin Mar 24, 2024
9206bd4
Remove PHP 8.0
andreybolonin Mar 26, 2024
f46a745
Update ci.yml
andreybolonin Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
strategy:
fail-fast: false
matrix:
php: ['8.0', '8.1', '8.2']
php: ['8.0', '8.1', '8.2', '8.3', '8.4']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's time to drop 8.0 from that list.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the include section to reflect that we test the lowest for PHP 8.1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvanlaak done

strategy: [ 'highest' ]
sf_version: ['']
include:
Expand Down
Loading