Warn/show failed XIncludes #227
Conversation
|
I plan to merge this latter in the day, and new QA tools by next week, as they are somewhat related. |
| $explain = false; | ||
|
|
||
| $xpath = new DOMXPath( $dom ); | ||
| $xpath->registerNamespace( "xi" , "http://www.w3.org/2001/XInclude" ); | ||
| $nodes = $xpath->query( "//xi:include" ); | ||
| foreach( $nodes as $node ) | ||
| { | ||
| if ( $header == false ) |
There was a problem hiding this comment.
What kind of formatting code style are you following? This line isn't following the same style as the line before it.
There was a problem hiding this comment.
In general, keyword space parenthesis, and spaces around parenthesis and operators. No space before parenthesis of functions or constructors. In this case, the line above that is wrongly formatted, but as it was not changed, I minimized the changes on the diff, not fixing it.
| @@ -1001,13 +1001,21 @@ function xinclude_residual( DOMDocument $dom ) | |||
| // XInclude failures are soft errors on translations, so remove | |||
| // residual XInclude tags on translations to keep them building. | |||
|
|
|||
| $header = false; | |||
There was a problem hiding this comment.
Maybe $hasHeader or $needsHeader. What does this variable represent?
There was a problem hiding this comment.
It was more in the sense of $headerDisplayed / printed / showed. A flag to print and not duplicated the header outpout.
There was a problem hiding this comment.
but it not being updated
it should be an array
An effective fix for #224. Will generate around or less than 10 warnings in almost all translations, where XInclude failures are "erasing" parts of manual translations.