Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhD stuff at end of configure.php #239

Merged
merged 7 commits into from
Mar 24, 2025
Merged

PhD stuff at end of configure.php #239

merged 7 commits into from
Mar 24, 2025

Conversation

alfsb
Copy link
Member

@alfsb alfsb commented Mar 14, 2025

This PR move all generation of PhD specific files to the end of configure.php, in particular, to after manual.xml validation, so the "time to validate" and "time to error" is vastly reduced on machines without SSD.

Also, this empathizes that these generated files are not relevant for manual.xml validation or generation, and so testing can concentrate on these functions alone.

Unrelated, but... time to remove the mention of nice in final messages?

@alfsb alfsb mentioned this pull request Mar 7, 2025
30 tasks
@alfsb alfsb merged commit 4e24cd6 into php:master Mar 24, 2025
12 checks passed
@alfsb alfsb deleted the phd-at-end branch March 24, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant