Remove GNU Readline in favor of libedit

[petk]

The libedit library is a non-GPL replacement for the GNU Readline library.

[Girgias]

Note the documentation shouldn't use personalization (i.e. using "you") maybe you could fix the text at the same time?

This feels like this should probably use some standard wording/an existing XML entity

[petk]

Fixed in the next commit. I'm not sure I know what "standard wording/an existing XML entity" means here.

[cmb69]

What is the actual status here? Apparently, the constant READLINE_LIB has not been removed, and there are still --with-libedit and --with-readline[=DIR]. Ah, php/php-src#15882 is still open, and php/php-src#13184 has not been merged. So the documentation changes need to be reverted for now.

[petk]

Yes, this was merged a bit too quickly. The code related PR wasn't merged to PHP 8.4 yet. Then let's merge it in PHP 8.5 or something.

[cmb69]

Reverted via 51779f7.

I think we should go ahead with the removal of libreadline support in php-src.

[petk]

I also think it's about time. Just for the info, it will be 6 years since the initial attempt to fix this and almost 1 year since the 2nd attempt. I'm actually quite amazed how long such issues take. And there is at least one more such issue - the gdbm library. At least from my current checks.

[cmb69]

I'm actually quite amazed how long such issues take.

Someone needs to push. :)

And there is at least one more such issue - the gdbm library.

I have no problems with dropping this one. Should probably also drop support for ancient Berkeley DB 1 - 3 (can't imagine anybody using these for years).

[petk]

This is really difficult to keep track of.