Document Dom\HTMLDocument methods #4314
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intentional |
Girgias
reviewed
Dec 20, 2024
language-snippets.ent
Outdated
Comment on lines
1758
to
1760
| The <link linkend="libxml.constants">LIBXML_NOEMPTYTAG</link> | ||
| and <link linkend="libxml.constants">LIBXML_NOXMLDECL</link> options are supported. | ||
| Prior to PHP 8.3.0, only the <link linkend="libxml.constants">LIBXML_NOEMPTYTAG</link> |
There was a problem hiding this comment.
You can just use the <constant> tags here
There was a problem hiding this comment.
Right, I made this mistake because this was copied+adapted
language-snippets.ent
Outdated
|
|
||
| <!ENTITY dom.parameter.compliant.encoding '<simpara xmlns="http://docbook.org/ns/docbook"> | ||
| The encoding that the document was created in. | ||
| If not provided, it will automatically detect the used encoding. |
There was a problem hiding this comment.
Not sure we should use "detect" here.
Maybe more something along the lines
It will attempt to determine the most likely encoding that is used
| &dom.errors.compliant.common; | ||
| <listitem> | ||
| <simpara> | ||
| Throws an <exceptionname>Exception</exceptionname> if |
There was a problem hiding this comment.
Is it generic or is it a DOMException?
There was a problem hiding this comment.
A normal Exception, DOM doesn't define this exception so it's not a DOMException.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.