Rewrite the callback and callable page #4933
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR rewrites the PHP documentation page for callbacks and callables to provide a more comprehensive and up-to-date explanation. The rewrite restructures the content with improved organization, adds detailed examples, and includes information about modern PHP features like first-class callable syntax.
- Complete restructuring of content with clearer explanations and better organization
- Addition of comprehensive examples demonstrating different ways to create and use callables
- Updated information about PHP 8.1+ features and deprecation warnings for PHP 8.2+
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
This is what the page looks like now: |
language/types/callable.xml
Outdated
| // An example callback function | ||
| function my_callback_function() { | ||
| echo 'hello world!', PHP_EOL; | ||
| echo 'hello world!', "\n"; |
There was a problem hiding this comment.
The usual style in the documentation is PHP_EOL.
There was a problem hiding this comment.
I don't think so. There is definitely more "\n" than PHP_EOL and I see no reason why we should use this constant here. We have been removing it in previous PRs so there is a precedent for it already.
There was a problem hiding this comment.
I have reverted it back per your request, but I believe that it is a bad practice to use this constant in a write context, and it's dangerous. We should not be teaching new users this.
| <simpara>String containing the name of a function or a method</simpara> | ||
| </listitem> | ||
| <listitem> | ||
| <simpara>Array containing a class name or an <type>object</type> |
There was a problem hiding this comment.
| <simpara>Array containing a class name or an <type>object</type> | |
| <simpara>&array; containing a class name or an <type>object</type> |
There was a problem hiding this comment.
Won't that make it lowercase?
Co-authored-by: Tim Düsterhus <[email protected]>
3 participants
No description provided.