feat: add cli_set_process_title() and cli_get_process_title()
#1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexandre-daubois
force-pushed
the
cli-set-get-proc-title
branch
from
3617d5e to
b7cb1ee
Compare
alexandre-daubois
force-pushed
the
cli-set-get-proc-title
branch
2 times, most recently
from
c425a05 to
d33de2f
Compare
|
The lint error is challenging somehow... The linter tells that the functions should not be redefined in the stub, but it won't work without it (the generated arginfo also contains function entries). I'm not sure how we can proceed... Maybe with function aliases? 🤔 |
If you would like to work on #1757 that would solve this implicitly as well. |
|
Indeed! I forgot about it. Let's close this one, the other PR is the way to go. |
|
I would actually say that with my changes merged, it's ready with static linking against libphp.a. You might even be familiar enough with php-src to deal with the tsrm_ls_cache symbol when linking against libphp.so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #587
Not a big fan of borrowing that much code from the cli sapi, but I'm not sure there's another solution actually