revert base64_encode change

NEWS

@@ -221,7 +221,7 @@ PHP                                                                        NEWS
   . Added the http_get_last_response_headers() and
     http_clear_last_response_headers() that allows retrieving the same content
     as the magic $http_response_header variable.
-  . Add padding option to base64_encode. (Remi)
+  . Add php_base64_encode_ex() API. (Remi)
 
 - XML:
   . Added XML_OPTION_PARSE_HUGE parser option. (nielsdos)

UPGRADING

@@ -136,8 +136,6 @@ PHP 8.4 UPGRADE NOTES
     PHP_ROUND_HALF_UP.
   . strcspn() with empty $characters now returns the length of the string instead
     of incorrectly stopping at the first NUL character. See GH-12592.
-  . base64_encode now have a $padding option (true by default) to allow
-    encoding without the padding character '='.
 
 - XML:
   . The xml_set_*_handler() functions now declare and check for an effective

UPGRADING.INTERNALS

@@ -213,7 +213,7 @@ PHP 8.4 INTERNALS UPGRADE NOTES
      pcre2_set_compile_extra_options() with those options.
 
  g. ext/standard
-   - Added the base64_encode_ex() API with flag parameters, value can be
+   - Added the php_base64_encode_ex() API with flag parameters, value can be
      PHP_BASE64_NO_PADDING to encode without the padding character '='.
 
 ========================

ext/standard/base64.c

@@ -1233,15 +1233,12 @@ PHP_FUNCTION(base64_encode)
 	char *str;
 	size_t str_len;
 	zend_string *result;
-	bool padding = true;
 
-	ZEND_PARSE_PARAMETERS_START(1, 2)
+	ZEND_PARSE_PARAMETERS_START(1, 1)
 		Z_PARAM_STRING(str, str_len)
-		Z_PARAM_OPTIONAL
-		Z_PARAM_BOOL(padding)
 	ZEND_PARSE_PARAMETERS_END();
 
-	result = php_base64_encode_ex((unsigned char*)str, str_len, (padding ? 0 : PHP_BASE64_NO_PADDING));
+	result = php_base64_encode((unsigned char*)str, str_len);
 	RETURN_STR(result);
 }
 /* }}} */

ext/standard/basic_functions.stub.php

@@ -1930,7 +1930,7 @@ function array_is_list(array $array): bool {}
  * @compile-time-eval
  * @refcount 1
  */
-function base64_encode(string $string, bool $padding = true): string {}
+function base64_encode(string $string): string {}
 
 /**
  * @compile-time-eval

ext/standard/tests/url/base64_encode_basic_001.phpt

@@ -29,8 +29,6 @@ $values = array(
 foreach($values as $str) {
     $enc = base64_encode($str);
     printf("%s\n", $enc);
-    $enc = base64_encode($str, padding: false);
-    printf("%s\n", $enc);
 }
 
 echo "Done\n";
@@ -294,21 +292,12 @@ echo "Done\n";
 0xFE: /g==
 0xFF: /w==
 SGVsbG8gV29ybGQ=
-SGVsbG8gV29ybGQ
 QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVoxMjM0NTY3ODkwISVeJiooKXt9W10=
-QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVoxMjM0NTY3ODkwISVeJiooKXt9W10
-CgkgTGluZSB3aXRoIGNvbnRyb2wgY2hhcmFjdGVycw0K
 CgkgTGluZSB3aXRoIGNvbnRyb2wgY2hhcmFjdGVycw0K
 wcLDxMXG
-wcLDxMXG
 PT4/BzgHOVw4MA==
-PT4/BzgHOVw4MA
 QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVphYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5ejAxMjM0NTY3ODklIQ==
-QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVphYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5ejAxMjM0NTY3ODklIQ
 QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVphYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5ejAxMjM0NTY3ODklIT0+Pwc4BzlcODA=
-QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVphYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5ejAxMjM0NTY3ODklIT0+Pwc4BzlcODA
 QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVphYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5ejAxMjM0NTY3ODklIUFCQ0RFRkdISUpLTE1OT1BRUlNUVVZXWFlaYWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXowMTIzNDU2Nzg5JSE=
-QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVphYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5ejAxMjM0NTY3ODklIUFCQ0RFRkdISUpLTE1OT1BRUlNUVVZXWFlaYWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXowMTIzNDU2Nzg5JSE
-QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVphYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5ejAxMjM0NTY3ODklIUFCQ0RFRkdISUpLTE1OT1BRUlNUVVZXWFlaYWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXowMTIzNDU2Nzg5JSE9Pj8HOAc5XDgw
 QUJDREVGR0hJSktMTU5PUFFSU1RVVldYWVphYmNkZWZnaGlqa2xtbm9wcXJzdHV2d3h5ejAxMjM0NTY3ODklIUFCQ0RFRkdISUpLTE1OT1BRUlNUVVZXWFlaYWJjZGVmZ2hpamtsbW5vcHFyc3R1dnd4eXowMTIzNDU2Nzg5JSE9Pj8HOAc5XDgw
 Done