Repeat JIT tests #12495
Repeat JIT tests #12495
Conversation
|
btw @iluuu1994 #12406 can be merged independently of this :) |
danog
changed the title
| @@ -43,6 +43,7 @@ runs: | |||
| export TEST_PHP_JUNIT=junit.out.xml | |||
| export STACK_LIMIT_DEFAULTS_CHECK=1 | |||
| sapi/cli/php run-tests.php -P -q ${{ inputs.runTestsParameters }} \ | |||
| ${{ inputs.jitType == 'disable' && '' || '--repeat 2' }} | |||
There was a problem hiding this comment.
CircleCI already tests with --repeat 2, I think that's enough.
.github/nightly_matrix.php
Outdated
| 'branch' => $branch, | ||
| 'debug' => true, | ||
| 'zts' => true, | ||
| 'configuration_parameters' => "CFLAGS='-fsanitize=undefined,address -DZEND_TRACK_ARENA_ALLOC' LDFLAGS='-fsanitize=undefined,address'", | ||
| 'run_tests_parameters' => '--asan', | ||
| 'test_function_jit' => false, |
There was a problem hiding this comment.
Note that function JIT was specifically disabled on ASAN because it exceeded the 6h limit on GitHub Actions.
| @@ -43,6 +43,7 @@ runs: | |||
| export TEST_PHP_JUNIT=junit.out.xml | |||
| export STACK_LIMIT_DEFAULTS_CHECK=1 | |||
| sapi/cli/php run-tests.php -P -q ${{ inputs.runTestsParameters }} \ | |||
| ${{ inputs.jitType == 'disable' && '' || '--repeat 2' }} | |||
There was a problem hiding this comment.
The issue with combining --repeat with ASAN is that --repeat disabled certain tests (e.g. all tests with a CLEAN section). So this would essentially stop testing all DB extensions on ASAN, amongst other things.
| @@ -83,7 +83,7 @@ set OPENSSL_CONF= | |||
| rem set SSLEAY_CONF= | |||
|
|
|||
| rem prepare for OPcache | |||
| if "%OPCACHE%" equ "1" set OPCACHE_OPTS=-d opcache.enable=1 -d opcache.enable_cli=1 -d opcache.protect_memory=1 -d opcache.jit_buffer_size=64M -d opcache.jit_max_root_traces=100000 -d opcache.jit_max_side_traces=100000 -d opcache.jit_max_exit_counters=100000 -d opcache.jit=tracing | |||
| if "%OPCACHE%" equ "1" set OPCACHE_OPTS=-d opcache.enable=1 -d opcache.enable_cli=1 -d opcache.protect_memory=1 -d opcache.jit_buffer_size=64M -d opcache.jit_max_root_traces=100000 -d opcache.jit_max_side_traces=100000 -d opcache.jit_max_exit_counters=100000 -d opcache.jit=tracing --repeat 2 | |||
There was a problem hiding this comment.
Same here, I don't think --repeat should be added unless we can make sure it works for all tests, or unless the architecture is already tested without --repeat.
.github/workflows/nightly.yml
Outdated
| echo memory_limit=-1 >> /etc/php.d/opcache.ini | ||
| php -v | ||
| - name: Test Infection |
There was a problem hiding this comment.
I think your PRs still do too much at a time 🙂 E.g. just adding Infection without jit_check.php or other changes would be much easier to review and merge.
danog
changed the title
Based on #12406, should be merged once #12428 + #12494 are closed