Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hosted docs link to docs/README.md #13633

Closed
wants to merge 3 commits into from
Closed

Add hosted docs link to docs/README.md #13633

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66e97d1
Add hosted docs link to docs/README.md
mvorisek Mar 8, 2024
0127ef1
address feedback
mvorisek Mar 8, 2024
54f2e42
fix strict 100 char line limit
mvorisek Mar 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion docs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
# php-src docs

This is the home of the php-src internal documentation. It is in very early stages, but is intended
This is the home of the php-src internal documentation, hosted at
[php.github.io/php-src/](https://php.github.io/php-src/). It is in very early stages, but is intended
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to be pedantic, these are 101 characters 🙂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there were another line over 100 chars

I wonder a little why 100 is the limit instead of typical 120 chars

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No special reason, just personal preference. I find it better for readability than 120 while not as extreme as 80.

to become the primary place where new information about php-src is documented. Over time, it is
expected to replace various mediums like:

Expand Down