Upgrade ci checkout version #15282
Closed
Upgrade ci checkout version #15282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* PHP-8.3: Revert "Skip bug45161.phpt on Windows"
Use our own string builder instead of using libxml's and then having to
copy over.
For the following test:
```
$dom = Dom\HTMLDocument::createEmpty();
$root = $dom->appendChild($dom->createElement('root'));
$root->append('abc', 'def', 'ghi');
$f = $root->firstChild;
for ($i = 0; $i < 1000000; $i++)
$f->wholeText;
```
The following results were obtained on an i7-4790:
```
Benchmark 1: ./sapi/cli/php x.php
Time (mean ± σ): 57.2 ms ± 2.3 ms [User: 53.2 ms, System: 3.4 ms]
Range (min … max): 54.7 ms … 69.3 ms 52 runs
Benchmark 2: ./sapi/cli/php_old x.php
Time (mean ± σ): 89.4 ms ± 3.4 ms [User: 85.6 ms, System: 3.0 ms]
Range (min … max): 86.1 ms … 105.8 ms 32 runs
Summary
./sapi/cli/php x.php ran
1.56 ± 0.09 times faster than ./sapi/cli/php_old x.php
```
As expected, ArrayObject is cursed
Follow-up for 2d029ef
see https://wiki.php.net/rfc/correctly_name_the_rounding_mode_and_make_it_an_enum Co-authored-by: Saki Takamachi <[email protected]> Co-authored-by: Niels Dossche <[email protected]>
This introduces a new helper php_dom_create_nullable_object() that does the NULL check and puts NULL in return_value. Otherwise it runs php_dom_create_object(). This deduplicates a bit of code.
This adds notice in the UPGRADING.INTERNALS file and removes redundant undefinition from Windows config header. Follow-up of phpGH-14942.
The zend_object.properties HashTable needs to be built just in time by calling rebuild_object_properties() on the object before accessing it. Normally this is done automatically in zend_std_get_properties(), but we do it manually in a few places. In this change I introduce an inline variant of zend_std_build_properties(), and refactor these places to use it instead of calling rebuild_object_properties() manually. rebuild_object_properties() renamed as rebuild_object_properties_internal(), to enforce usage of zend_std_get_properties() or zend_std_build_properties_ex(). Closes phpGH-14996
* PHP-8.2: Update the php-sdk-binary-tools to php-sdk-2.3.0
* PHP-8.3: Update the php-sdk-binary-tools to php-sdk-2.3.0
This makes the developer intent clear and should prevent some false reports.
* PHP-8.2: Fix phpGH-15028: Memory leak in ext/phar/stream.c Fix phpGH-15023: Memory leak in Zend/zend_ini.c Fix phpGH-15020: Memory leak in Zend/Optimizer/escape_analysis.c
* PHP-8.3: Fix phpGH-15028: Memory leak in ext/phar/stream.c Fix phpGH-15023: Memory leak in Zend/zend_ini.c Fix phpGH-15020: Memory leak in Zend/Optimizer/escape_analysis.c
Quoted m4_normalize will expand and change its argument later in the macro call when M4 is processing the *.m4 sources. Without quotes the already normalized string is passed to the macro directly. In these specific cases generated configure script is the same. This is more for consistency to have this synced and not repeat the pattern too much in the future when copy/pasting. Note, that many AC_* macros require similar behavior already (for example, AC_CHECK_FUNCS.)
AIX 7.1 has SOCK_CONN_DGRAM, but not SOCK_DCCP; the previous change conflated the availability between the two definitions. Add an additional #ifdef for this.
- PHP_ADD_INCLUDE - PHP_EVAL_INCLINE - PHP_EVAL_LIBLINE
Co-authored-by: Tim Düsterhus <[email protected]>
The parent's child must exist because otherwise this node could not have a parent node.
- AC_MSG_CHECKING - AC_MSG_RESULT - AC_MSG_WARN - AC_MSG_ERROR - AC_MSG_NOTICE
- AC_* macros simplified and arguments quoted
I don't know why this code was here in the first place, it is present since the initial implementation. It doesn't make sense because: 1. It would require updating the refcounts if the document wasn't actually already set. 2. We enforce that the document is the same as the target document by this point, so setting the tree is pointless.
Disservin
requested review from
adoy,
SakiTakamachi and
TimWolla
as code owners
github-actions
bot
added
Category: Build System
Category: Engine
Extension: intl
Extension: bcmath
Extension: bz2
Extension: calendar
Extension: com_dotnet
Extension: ctype
Extension: curl
Extension: date
Extension: dba
Extension: dom
Extension: enchant
Extension: exif
Extension: ffi
Extension: fileinfo
Extension: filter
Extension: ftp
Extension: gd
Extension: gettext
Extension: gmp
Extension: hash
Extension: iconv
Extension: imap
Category: Optimizer
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reference #15281