Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Doc shell script on unix #16676

Closed

Conversation

liuuniverse
Copy link

Introduction

It was found that there was no shell script available for generating documents on Unix systems in the doc directory, so a new one was added.

Change Details

Added a new file: ./doc/make.sh
Modified the file: ./doc/README.md

@hakre
Copy link
Contributor

hakre commented Nov 16, 2024

@liuuniverse Sorry, I have not seen the PR here you opened earlier, only yesterday I was made aware of it.

There was some traction to get the build going on *nix systems in #16743 and it is adding a Makefile.

Would this already work for you, too?

In any case, please let me know any questions or comments and how you prefer to go on.

@liuuniverse
Copy link
Author

@hakre Thank you for your update and for looking into my PR. I think the approach in #16743 is excellent, and I fully support using a Makefile for managing the build process in a more streamlined manner.

I also appreciate the effort you've put into updating the documentation.

👍 To save everyone's time and effort, I will close my current PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants