Support alternative color quantization algorithms #17270
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As is, ext/gd only supports the default color quantization algorithm, which is used for `imagetruecolortopalette()`. However, libgd supports alternative algorithms as of GD 2.1.0, namely NeuQuant (which is built in) and libimagequant (which is used by pngquant). We add support for these alternative color quantization algorithms as small wrappers around the two respective libgd functions, introducing also a couple of constants. We also add the nnquant module to our bundled libgd.
devnexen
reviewed
Dec 26, 2024
devnexen
reviewed
Dec 26, 2024
| if (gdImageTrueColorToPaletteSetMethod(im, method, speed)) { | ||
| RETURN_TRUE; | ||
| } else { | ||
| php_error_docref(NULL, E_WARNING, "Couldn't set quantization method"); |
There was a problem hiding this comment.
Question you know better gd than I do, seems to me the only failure case left is when the method is not available correct ? so always will be unavailable then. dunno if we should raise an exception and this call only returns true.
There was a problem hiding this comment.
I think I agree, but we should add info about the available quantization methods first.
We might need to check for vcomp140.dll, too.
* proper range check for $method * error message must refer to `IMG_QUANT_*` * gd_topal.c must include libimagequant.h (like upstream does) * fix _aligned_malloc() arguments <libgd/libgd#914>
|
While adding a new test case, I've noticed that two others would fail when libimagequant is available. I'm somewhat surprised that this apparently hasn't been reported already. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is, ext/gd only supports the default color quantization algorithm, which is used for
imagetruecolortopalette(). However, libgd supports alternative algorithms as of GD 2.1.0, namely NeuQuant (which is built in) and libimagequant (which is used by pngquant).We add support for these alternative color quantization algorithms as small wrappers around the two respective libgd functions, introducing also a couple of constants. We also add the nnquant module to our bundled libgd.
TODO:
References:
https://libgd.github.io/manuals/2.3.3/files/gd_topal-c.html