Fixed GH-17275: Fixed the calculation logic of dividend scale. #17279
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SakiTakamachi
changed the title
nielsdos
approved these changes
Dec 27, 2024
There was a problem hiding this comment.
Looks correct.
The numerator_readable_len >= scale_diff condition could be changed to numerator_readable_len > scale_diff to be similar to other conditions, but it doesn't really matter as the resulting computation will be the same. (You don't have to change this, just noting)
|
@nielsdos |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17275
I feel like this part of the code has finally turned into the correct version….
I've tried about 1 million patterns, and so far all the results have been the same as in past versions, so I think the bug has settled down for now.....