ext/sockets: inet family conversions internal changes. #17297
+98
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Girgias
reviewed
Dec 29, 2024
ext/sockets/sockaddr_conv.c
Outdated
| @@ -13,7 +13,7 @@ extern zend_result php_string_to_if_index(const char *val, unsigned *out); | |||
|
|
|||
| #ifdef HAVE_IPV6 | |||
| /* Sets addr by hostname, or by ip in string form (AF_INET6) */ | |||
| int php_set_inet6_addr(struct sockaddr_in6 *sin6, char *string, php_socket *php_sock) /* {{{ */ | |||
| zend_result php_set_inet6_addr(struct sockaddr_in6 *sin6, char *string, php_socket *php_sock) /* {{{ */ | |||
There was a problem hiding this comment.
You could use bool here instead of zend_result this would preserve the existing semantics
There was a problem hiding this comment.
I did that at first but was to make it consistent with the callers e.g. here.
There was a problem hiding this comment.
How public are these APIs? Because it might make more sense to change the callers API to return a bool (which is static here).
ext/sockets/sockaddr_conv.c
Outdated
| } | ||
| /* }}} */ | ||
| #endif | ||
|
|
||
| /* Sets addr by hostname, or by ip in string form (AF_INET) */ | ||
| int php_set_inet_addr(struct sockaddr_in *sin, char *string, php_socket *php_sock) /* {{{ */ | ||
| zend_result php_set_inet_addr(struct sockaddr_in *sin, char *string, php_socket *php_sock) /* {{{ */ |
ext/sockets/sockaddr_conv.c
Outdated
| } | ||
| /* }}} */ | ||
|
|
||
| /* Sets addr by hostname or by ip in string form (AF_INET or AF_INET6, | ||
| * depending on the socket) */ | ||
| int php_set_inet46_addr(php_sockaddr_storage *ss, socklen_t *ss_len, char *string, php_socket *php_sock) /* {{{ */ | ||
| zend_result php_set_inet46_addr(php_sockaddr_storage *ss, socklen_t *ss_len, char *string, php_socket *php_sock) /* {{{ */ |
devnexen
force-pushed
the
socketaddr_conv_changes
branch
2 times, most recently
from
1690118 to
9beedba
Compare
devnexen
force-pushed
the
socketaddr_conv_changes
branch
from
9beedba to
99f91bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.