Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/gmp: allow real number to create gmp int. #18254

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ext/gmp: allow real number to create gmp int. #18254

wants to merge 1 commit into from

Conversation

devnexen
Copy link
Member

@devnexen devnexen commented Apr 5, 2025

No description provided.

@devnexen
Copy link
Member Author

devnexen commented Apr 5, 2025

cc @Girgias before I ever fix the tests, let me know that s a direction you wanna see to begin with.

Girgias
Girgias reviewed Apr 5, 2025
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I want to add support for converting a float to a GMP object.

My main concern is that for integers larger than 53 bits converting from float and back looses precision. As this is the precision of the mantissa.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Girgias Girgias Girgias left review comments

Assignees
No one assigned
Labels
Extension: gmp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devnexen @Girgias