Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ext/standard: Remove #[\NoDiscard] from flock() #18255

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

ext/standard: Remove #[\NoDiscard] from flock() #18255

wants to merge 1 commit into from
+71 −66

Conversation

TimWolla
Copy link
Member

@TimWolla TimWolla commented Apr 5, 2025 •
edited
Loading

Closes #18235
Closes php/doc-en#4581

@TimWolla TimWolla force-pushed the flock-no-nodiscard branch from b7b1f53 to c9af652 Compare April 6, 2025 13:14
iluuu1994
iluuu1994 approved these changes Apr 6, 2025
View reviewed changes
Copy link
Member

@iluuu1994 iluuu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iluuu1994 iluuu1994 iluuu1994 approved these changes

@kocsismate kocsismate Awaiting requested review from kocsismate kocsismate is a code owner

@bukka bukka Awaiting requested review from bukka bukka is a code owner

@dstogov dstogov Awaiting requested review from dstogov dstogov is a code owner

Assignees
No one assigned
Labels
ABI break Extension: opcache Extension: standard Extension: zend_test
Projects
None yet
Milestone
No milestone
2 participants
@TimWolla @iluuu1994